Prepare release/v0.19 branch#60
Merged
Merged
Conversation
0c3af3a to
ca980f1
Compare
a65df24 to
debf359
Compare
018fcf8 to
36dff04
Compare
peter-marcisovsky
approved these changes
Oct 14, 2025
| export EXTRA_CXXFLAGS="${PEDANTIC_FLAGS}" | ||
| python .github/ci/override_managed_component.py tinyusb . ${{ env.ESP_TINYUSB_TEST_APPS }}/*/ | ||
| idf-build-apps find --path ${{ env.ESP_TINYUSB_TEST_APPS }}/ --recursive --target esp32s2 --manifest-file ${{ env.ESP_USB_MANIFEST }} | ||
| idf-build-apps build --path ${{ env.ESP_TINYUSB_TEST_APPS }}/ --recursive --target esp32s2 --manifest-file ${{ env.ESP_USB_MANIFEST }} |
Collaborator
There was a problem hiding this comment.
Build only for esp32s2 ? Since you are using build-test-rules.yml from esp-usb you can set --target all and the SOC_CAPS will sort the targets.
There was a problem hiding this comment.
As we also have the network example in the build step, apply --target all is relevant only for usb_test_apps.
Enabling the same in the esp_idf_examples will lead to build the sta2eth example for all supported targets, not only the one relevant for us.
UPD:
part of the log from the last run (duration of the step ~6 minutes):
(cmake) App /opt/esp/idf/examples/network/sta2eth/, target esp32, sdkconfig (default), build in /opt/esp/idf/examples/network/sta2eth/build
45
(cmake) App /opt/esp/idf/examples/network/sta2eth/, target esp32c2, sdkconfig (default), build in /opt/esp/idf/examples/network/sta2eth/build
46
(cmake) App /opt/esp/idf/examples/network/sta2eth/, target esp32c3, sdkconfig (default), build in /opt/esp/idf/examples/network/sta2eth/build
47
(cmake) App /opt/esp/idf/examples/network/sta2eth/, target esp32c6, sdkconfig (default), build in /opt/esp/idf/examples/network/sta2eth/build
48
(cmake) App /opt/esp/idf/examples/network/sta2eth/, target esp32s2, sdkconfig (default), build in /opt/esp/idf/examples/network/sta2eth/build
49
(cmake) App /opt/esp/idf/examples/network/sta2eth/, target esp32s3, sdkconfig (default), build in /opt/esp/idf/examples/network/sta2eth/build
b669329 to
d350b1e
Compare
roma-jam
reviewed
Oct 15, 2025
61be9a2 to
fc59411
Compare
fc59411 to
d2cdc3d
Compare
tore-espressif
commented
Oct 17, 2025
tore-espressif
left a comment
Collaborator
Author
There was a problem hiding this comment.
I had to
- remove esp_tinyusb test-apps run because it is very difficult to maintain.
- comment out preview builds, as they are not stable (currently not passing with esp-idf:latest docker, but passing locally)
This was referenced Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ToDo
Changes compared to release/v0.18
idf-build-appsin GH workflowsupload-components-ci-actionto v2idf_component.ymlidf_component.ymltusb_teardown()now renamed totusb_deinit()Closes espressif/esp-usb#280